Add tests for remove-user with a rolebinding name #18602
Conversation
openshift-ci-robot
added
the
size/XS
|
@enj PTAL |
|
/retest |
|
@simo5 can you also add a test like my example from #18102 (comment) (remove-role-from-user). |
test/cmd/policy.sh
Outdated
| @@ -54,6 +54,10 @@ os::cmd::expect_success_and_text 'oc policy add-role-to-group cluster-admin --ro | |||
| os::cmd::expect_success_and_text 'oc policy add-role-to-user --rolebinding-name cluster-admin cluster-admin system:no-user' 'role "cluster-admin" added: "system:no-user"' | |||
| os::cmd::expect_success 'oc get rolebinding/cluster-admin --no-headers' | |||
| os::cmd::expect_success_and_text 'oc get rolebinding/cluster-admin --no-headers' 'system:no-user' | |||
| # Test failure to mix and mismatch | |||
| os::cmd::expect_success 'oc create rolebinding mismatch --clusterrole=cluster-admin --user=system:user' | |||
| os::cmd::expect_failure 'oc policy remove-user --rolebinding-name mismatch system:no-user' | |||
There was a problem hiding this comment.
os::cmd::expect_failure_and_text with specific failure
|
I could go the whole project creation route like your example, but it's a ton of test overhead for no additional value. |
|
And of course there is no --rolebinding-name option on this command ... FAIL! :-) |
Signed-off-by: Simo Sorce <simo@redhat.com>
openshift-ci-robot
added
size/S
|
Overhauled the test to use a project and checks for rolebinding mismatches |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, simo5 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-ci-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Automatic merge from submit-queue. Add tests for remove-user with a rolebinding name Fixes openshift#18582
Fixes #18582