Skip to content

OCPNODE-3004: Add ImageVolume e2e tests #30015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

OCPNODE-3004: Add ImageVolume e2e tests #30015

merged 1 commit into from
Jul 28, 2025

Conversation

saschagrunert
Copy link
Member

Adding an imagevolume e2e test by carrying over #29987

Credits go to @bitoku

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 24, 2025 •
edited by openshift-ci bot
Loading

@saschagrunert: This pull request references OCPNODE-3004 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Adding an imagevolume e2e test by carrying over #29987

Credits go to @bitoku

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@saschagrunert saschagrunert mentioned this pull request Jul 24, 2025
Closed
@saschagrunert
Copy link
Member Author

@haircommander PTAL

@openshift-ci openshift-ci bot requested review from deads2k and p0lyn0mial July 24, 2025 07:39
@saschagrunert @bitoku
OCPNODE-3004: Add ImageVolume e2e tests
3aaa9ad 
Adding an imagevolume e2e test

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Co-authored-by: Ayato Tokubi <atokubi@redhat.com>
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/skip

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

@saschagrunert: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-rt-upgrade 3aaa9ad link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-vsphere-ovn-etcd-scaling 3aaa9ad link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-gcp-ovn-techpreview-serial-2of2 3aaa9ad link false /test e2e-gcp-ovn-techpreview-serial-2of2
ci/prow/e2e-azure-ovn-etcd-scaling 3aaa9ad link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 3aaa9ad link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-openstack-serial 3aaa9ad link false /test e2e-openstack-serial
ci/prow/e2e-gcp-ovn-etcd-scaling 3aaa9ad link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-aws-disruptive 3aaa9ad link false /test e2e-aws-disruptive
ci/prow/e2e-aws-ovn-single-node-upgrade 3aaa9ad link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-etcd-scaling 3aaa9ad link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-upgrade 3aaa9ad link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-gcp-disruptive 3aaa9ad link false /test e2e-gcp-disruptive
ci/prow/e2e-openstack-ovn 3aaa9ad link false /test e2e-openstack-ovn
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway 3aaa9ad link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/okd-scos-e2e-aws-ovn 3aaa9ad link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-fips-serial-1of2 3aaa9ad link false /test e2e-gcp-fips-serial-1of2
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 3aaa9ad link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-gcp-fips-serial-2of2 3aaa9ad link false /test e2e-gcp-fips-serial-2of2
ci/prow/e2e-metal-ipi-ovn-dualstack 3aaa9ad link false /test e2e-metal-ipi-ovn-dualstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt openshift-trt
Copy link

openshift-trt bot commented Jul 24, 2025

Job Failure Risk Analysis for sha: 3aaa9ad

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-vsphere-ovn-etcd-scaling Medium
[bz-openshift-apiserver] clusteroperator/openshift-apiserver should not change condition/Available
This test has passed 97.37% of 4256 runs on release 4.20 [Overall] in the last week.

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 3aaa9ad

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview Medium - "[sig-node] [FeatureGate:ImageVolume] ImageVolume should fail when image does not exist [Suite:openshift/conformance/parallel]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview Medium - "[sig-node] [FeatureGate:ImageVolume] ImageVolume should handle multiple image volumes [Suite:openshift/conformance/parallel]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview Medium - "[sig-node] [FeatureGate:ImageVolume] ImageVolume should succeed if image volume is not existing but unused [Suite:openshift/conformance/parallel]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview Medium - "[sig-node] [FeatureGate:ImageVolume] ImageVolume should succeed with multiple pods and same image on the same node [Suite:openshift/conformance/parallel]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview Medium - "[sig-node] [FeatureGate:ImageVolume] ImageVolume should succeed with pod and pull policy of Always [Suite:openshift/conformance/parallel]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview Medium - "[sig-node] [FeatureGate:ImageVolume] ImageVolume when subPath is used should fail to mount image volume with invalid subPath [Suite:openshift/conformance/parallel]" is a new test, and was only seen in one job.
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview Medium - "[sig-node] [FeatureGate:ImageVolume] ImageVolume when subPath is used should handle image volume with subPath [Suite:openshift/conformance/parallel]" is a new test, and was only seen in one job.

New tests seen in this PR at sha: 3aaa9ad

  • "[sig-node] [FeatureGate:ImageVolume] ImageVolume should fail when image does not exist [Suite:openshift/conformance/parallel]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-node] [FeatureGate:ImageVolume] ImageVolume should handle multiple image volumes [Suite:openshift/conformance/parallel]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-node] [FeatureGate:ImageVolume] ImageVolume should succeed if image volume is not existing but unused [Suite:openshift/conformance/parallel]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-node] [FeatureGate:ImageVolume] ImageVolume should succeed with multiple pods and same image on the same node [Suite:openshift/conformance/parallel]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-node] [FeatureGate:ImageVolume] ImageVolume should succeed with pod and pull policy of Always [Suite:openshift/conformance/parallel]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-node] [FeatureGate:ImageVolume] ImageVolume when subPath is used should fail to mount image volume with invalid subPath [Suite:openshift/conformance/parallel]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]
  • "[sig-node] [FeatureGate:ImageVolume] ImageVolume when subPath is used should handle image volume with subPath [Suite:openshift/conformance/parallel]" [Total: 1, Pass: 1, Fail: 0, Flake: 0]

@haircommander
Copy link
Member

/lgtm

thanks!

@saschagrunert
Copy link
Member Author

PTAL @bertinatto @DennisPeriquet @deads2k @dgoodwin @neisw @soltysh @stbenjam @xueqzhan @sosiouxme @smg247
for approval

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2025
@haircommander
Copy link
Member

/skip

@stbenjam
Copy link
Member

/approve

@bitoku
Copy link
Contributor

bitoku commented Jul 28, 2025

/assign

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, saschagrunert, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2025
@haircommander
Copy link
Member

/label acknowledge-critical-fixes-only

tests are green and only run in TP. we need soak time for the tests to make sure we have enough feedback to go GA before the freeze

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jul 28, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 48d56f2 and 2 for PR HEAD 3aaa9ad in total

@haircommander
Copy link
Member

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit debace2 into openshift:main Jul 28, 2025
57 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.20.0-202507282313.p0.gdebace2.assembly.stream.el9.
All builds following this will include this PR.

@saschagrunert saschagrunert deleted the image-volume-e2e branch July 29, 2025 05:55
@bitoku bitoku mentioned this pull request Jul 29, 2025
Merged
jluhrsen added a commit to jluhrsen/origin that referenced this pull request Aug 21, 2025
@jluhrsen
CI snapshot: state just before PR openshift#30015 merged
279612a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

Assignees

@bitoku bitoku

@haircommander haircommander

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@saschagrunert @openshift-ci-robot @haircommander @stbenjam @bitoku @openshift-bot