OCPBUGS-60489: monitoring: reapply separate type for localhost disruptions #30137

vrutkovs · 2025-08-20T07:51:46Z

These are replaced by pkg/monitortests/kubeapiserver/disruptionexternalapiserver and pkg/monitortests/kubeapiserver/disruptioninclusterapiserver.

This also partially re-applies #29710, reverted in #30034 to make sure localhost disruptions have a separate source set:

        {
            "level": "Info",
            "source": "DisruptionLocalhost",
            "locator": {
                "type": "Disruption",
                "keys": {
                    "backend-disruption-name": "kube-api-http1-localhost-new-connections",
                    "connection": "new",
                    "disruption": "kube-api-http1-localhost",
                    "load-balancer": "localhost",
...

openshift-ci · 2025-08-20T07:51:50Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2025-08-20T07:52:03Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vrutkovs · 2025-08-20T07:52:24Z

/test e2e-aws-ovn

dgoodwin · 2025-08-20T10:56:48Z

pkg/monitortests/kubeapiserver/legacykubeapiservermonitortests/monitortest.go

-}
-
-func (*legacyMonitorTests) ConstructComputedIntervals(ctx context.Context, startingIntervals monitorapi.Intervals, recordedResources monitorapi.ResourcesMap, beginning, end time.Time) (monitorapi.Intervals, error) {
-	return nil, nil


With no construct computed intervals or write content to storage, I don't think can be what's producing localhost disruption intervals.

vrutkovs · 2025-08-20T11:14:02Z

Yup, still seeing

        {
            "level": "Info",
            "source": "Disruption",
            "locator": {
                "type": "Disruption",
                "keys": {
                    "backend-disruption-name": "kube-api-http1-localhost-new-connections",
                    "connection": "new",
                    "disruption": "kube-api-http1-localhost",
                    "load-balancer": "localhost",
                    ...

although expected location type would be DisruptionLocalhost

vrutkovs · 2025-08-20T11:19:33Z

/test e2e-aws-ovn

openshift-ci-robot · 2025-08-20T14:42:42Z

@vrutkovs: This pull request references Jira Issue OCPBUGS-60489, which is invalid:

expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

These are replaced by pkg/monitortests/kubeapiserver/disruptionexternalapiserver and pkg/monitortests/kubeapiserver/disruptioninclusterapiserver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

vrutkovs · 2025-08-20T14:44:29Z

/jira refresh

openshift-ci-robot · 2025-08-20T14:44:37Z

@vrutkovs: This pull request references Jira Issue OCPBUGS-60489, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.0) matches configured target version for branch (4.20.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dgoodwin · 2025-08-21T11:23:51Z

pkg/monitortests/kubeapiserver/legacykubeapiservermonitortests/monitortest.go

-	junits = append(junits, testPodNodeNameIsImmutable(finalIntervals)...)
-	junits = append(junits, testStaticPodLifecycleFailure(finalIntervals, w.adminRESTConfig)...)
-	junits = append(junits, testAPIServerIPTablesAccessDisruption(finalIntervals)...)
-	junits = append(junits, testEarlyE2EAPIServerDisruption(finalIntervals, w.adminRESTConfig)...)


still four tests being killed off here which I don't think is intended any longer.

dgoodwin · 2025-08-21T11:24:05Z

pkg/defaultmonitortests/types.go

@@ -176,7 +175,6 @@ func newUniversalMonitorTests(info monitortestframework.MonitorTestInitializatio
 	monitorTestRegistry.AddMonitorTestOrDie("legacy-etcd-invariants", "etcd", legacyetcdmonitortests.NewLegacyTests())

 	monitorTestRegistry.AddMonitorTestOrDie("audit-log-analyzer", "kube-apiserver", auditloganalyzer.NewAuditLogAnalyzer())
-	monitorTestRegistry.AddMonitorTestOrDie("legacy-kube-apiserver-invariants", "kube-apiserver", legacykubeapiservermonitortests.NewLegacyTests())


Needs to be restored.

…r localhost" Make sure disruption JSON has special type for localhost disruptions. Spyglass template is left as is

vrutkovs · 2025-08-22T06:50:50Z

/retest-required

openshift-ci · 2025-08-22T10:07:12Z

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-disruptive	`5af4d6b`	link	false	`/test e2e-aws-disruptive`
ci/prow/e2e-gcp-ovn-techpreview-serial-1of2	`5af4d6b`	link	false	`/test e2e-gcp-ovn-techpreview-serial-1of2`
ci/prow/e2e-gcp-csi	`5af4d6b`	link	false	`/test e2e-gcp-csi`
ci/prow/e2e-openstack-ovn	`5af4d6b`	link	false	`/test e2e-openstack-ovn`
ci/prow/e2e-gcp-ovn-rt-upgrade	`5af4d6b`	link	false	`/test e2e-gcp-ovn-rt-upgrade`
ci/prow/e2e-gcp-ovn-techpreview-serial-2of2	`5af4d6b`	link	false	`/test e2e-gcp-ovn-techpreview-serial-2of2`
ci/prow/e2e-metal-ipi-virtualmedia	`5af4d6b`	link	false	`/test e2e-metal-ipi-virtualmedia`
ci/prow/e2e-aws-ovn-single-node-serial	`5af4d6b`	link	false	`/test e2e-aws-ovn-single-node-serial`
ci/prow/e2e-aws-ovn-single-node-upgrade	`5af4d6b`	link	false	`/test e2e-aws-ovn-single-node-upgrade`
ci/prow/e2e-metal-ipi-serial-ovn-ipv6-2of2	`5af4d6b`	link	false	`/test e2e-metal-ipi-serial-ovn-ipv6-2of2`
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway	`5af4d6b`	link	false	`/test e2e-metal-ipi-ovn-dualstack-local-gateway`
ci/prow/e2e-aws-proxy	`5af4d6b`	link	false	`/test e2e-aws-proxy`
ci/prow/e2e-gcp-ovn-techpreview	`5af4d6b`	link	false	`/test e2e-gcp-ovn-techpreview`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-trt · 2025-08-22T10:15:23Z

Job Failure Risk Analysis for sha: 5af4d6b

Job Name	Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-single-node-upgrade	IncompleteTests Tests for this run (2120) are below the historical average (4176): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2025

dgoodwin reviewed Aug 20, 2025

View reviewed changes

vrutkovs changed the title ~~monitoring: remove legacy kubeapiserver disruption tests~~ monitoring: remove legacy kubeapiserver disruption tests, reapply separate type for localhost disruptions Aug 20, 2025

vrutkovs changed the title ~~monitoring: remove legacy kubeapiserver disruption tests, reapply separate type for localhost disruptions~~ OCPBUGS-60489: monitoring: remove legacy kubeapiserver disruption tests, reapply separate type for localhost disruptions Aug 20, 2025

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 20, 2025

vrutkovs marked this pull request as ready for review August 20, 2025 14:43

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 20, 2025

openshift-ci bot requested review from deads2k and sjenning August 20, 2025 14:45

dgoodwin reviewed Aug 21, 2025

View reviewed changes

Partially reapply "OCPBUGS-55238: spyglass: hide disruption events fo…

5af4d6b

…r localhost" Make sure disruption JSON has special type for localhost disruptions. Spyglass template is left as is

vrutkovs force-pushed the remove-legacy-disruptions branch from 452bda3 to 5af4d6b Compare August 21, 2025 13:39

vrutkovs changed the title ~~OCPBUGS-60489: monitoring: remove legacy kubeapiserver disruption tests, reapply separate type for localhost disruptions~~ OCPBUGS-60489: monitoring: reapply separate type for localhost disruptions Aug 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

OCPBUGS-60489: monitoring: reapply separate type for localhost disruptions #30137

OCPBUGS-60489: monitoring: reapply separate type for localhost disruptions #30137

Uh oh!

vrutkovs commented Aug 20, 2025 •

edited

Loading

Uh oh!

openshift-ci bot commented Aug 20, 2025

Uh oh!

openshift-ci bot commented Aug 20, 2025

Uh oh!

vrutkovs commented Aug 20, 2025

Uh oh!

dgoodwin Aug 20, 2025

Uh oh!

vrutkovs commented Aug 20, 2025

Uh oh!

vrutkovs commented Aug 20, 2025

Uh oh!

openshift-ci-robot commented Aug 20, 2025

Uh oh!

vrutkovs commented Aug 20, 2025

Uh oh!

openshift-ci-robot commented Aug 20, 2025

Uh oh!

dgoodwin Aug 21, 2025

Uh oh!

dgoodwin Aug 21, 2025

Uh oh!

vrutkovs Aug 21, 2025

Uh oh!

vrutkovs commented Aug 22, 2025

Uh oh!

openshift-ci bot commented Aug 22, 2025

Uh oh!

openshift-trt bot commented Aug 22, 2025

Uh oh!

Uh oh!

OCPBUGS-60489: monitoring: reapply separate type for localhost disruptions #30137

Are you sure you want to change the base?

OCPBUGS-60489: monitoring: reapply separate type for localhost disruptions #30137

Uh oh!

Conversation

vrutkovs commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Aug 20, 2025

Uh oh!

openshift-ci bot commented Aug 20, 2025

Uh oh!

vrutkovs commented Aug 20, 2025

Uh oh!

dgoodwin Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

vrutkovs commented Aug 20, 2025

Uh oh!

vrutkovs commented Aug 20, 2025

Uh oh!

openshift-ci-robot commented Aug 20, 2025

Uh oh!

vrutkovs commented Aug 20, 2025

Uh oh!

openshift-ci-robot commented Aug 20, 2025

Uh oh!

dgoodwin Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

dgoodwin Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

vrutkovs Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

vrutkovs commented Aug 22, 2025

Uh oh!

openshift-ci bot commented Aug 22, 2025

Uh oh!

openshift-trt bot commented Aug 22, 2025

Uh oh!

Uh oh!

vrutkovs commented Aug 20, 2025 •

edited

Loading