Skip to content

Conversation

mshort55
Copy link
Contributor

@mshort55 mshort55 commented Aug 27, 2025

https://issues.redhat.com/browse/ACM-23012

Adding prow config files for stolostron/multicluster-role-assignment

Signed-off-by: Matthew Short <mshort@redhat.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 27, 2025
Copy link
Contributor

openshift-ci bot commented Aug 27, 2025

Hi @mshort55. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from Kyl-Bempah and smithbw88 August 27, 2025 23:02
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 27, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mshort55: no rehearsable tests are affected by this change

@mshort55
Copy link
Contributor Author

/cc @fxiang1

@openshift-ci openshift-ci bot requested a review from fxiang1 August 27, 2025 23:07
@fxiang1
Copy link
Contributor

fxiang1 commented Aug 28, 2025

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 28, 2025
@fxiang1
Copy link
Contributor

fxiang1 commented Aug 28, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2025
Copy link
Contributor

@mark-nc mark-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2025
Copy link
Contributor

openshift-ci bot commented Aug 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxiang1, mark-nc, mshort55

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c1b4605 into openshift:master Aug 28, 2025
9 of 10 checks passed
Copy link
Contributor

openshift-ci bot commented Aug 28, 2025

@mshort55: Updated the following 2 configmaps:

  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-stolostron-multicluster-role-assignment-_pluginconfig.yaml using file core-services/prow/02_config/stolostron/multicluster-role-assignment/_pluginconfig.yaml
  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-stolostron-multicluster-role-assignment-_prowconfig.yaml using file core-services/prow/02_config/stolostron/multicluster-role-assignment/_prowconfig.yaml

In response to this:

https://issues.redhat.com/browse/ACM-23012

Adding prow config files for stolostron/multicluster-role-assignment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

etmurasaki pushed a commit to etmurasaki/release that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants