Skip to content

fix(ui): do not paginate job variables #6198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2022
Merged

fix(ui): do not paginate job variables #6198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fdd156
fix(ui): do not paginate job variables
sguiheux Jun 9, 2022
266686c
fix(ui): use step name instead of action name
sguiheux Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/src/app/shared/action/step/step.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
<!-- Step name -->
<nz-col [nzSpan]="5">
<ng-container *ngIf="edit">
<input nz-input name="stepName" [(ngModel)]="step.name" (keydown)="action.hasChanged = true">
<input nz-input name="stepName" [(ngModel)]="step.step_name" (keydown)="action.hasChanged = true">
</ng-container>
<ng-container *ngIf="!edit">
{{step.name}}
{{step.step_name}}
</ng-container>
</nz-col>
<!-- Link to documentation -->
Expand Down
2 changes: 1 addition & 1 deletion ui/src/app/shared/parameter/list/parameter.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<nz-table nzShowPagination [nzData]="parameters" nzPageSize="5" #paramsList *ngIf="ready && parameters?.length > 0">
<nz-table nzShowPagination [nzData]="parameters" nzPageSize="5" #paramsList *ngIf="ready && parameters?.length > 0" [nzFrontPagination]="mode === 'job'?false:true">
<thead>
<tr *ngIf="mode !== 'launcher' && mode !== 'job'">
<th nzWidth="200px">Name</th>
Expand Down