Skip to content

Conversation

gengliqi
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #61826, #62421, #62414

Problem Summary:

What changed and how does it work?

Cherry-pick #62355, #62085 and #62386 to release-8.5

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

gengliqi and others added 3 commits August 28, 2025 19:14
…n failure pingcap#62355

Signed-off-by: gengliqi <gengliqiii@gmail.com>
…tiflash pingcap#62085

Signed-off-by: gengliqi <gengliqiii@gmail.com>
…ca_read set to closest_replica pingcap#62386

Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 28, 2025
@gengliqi
Copy link
Contributor Author

/cc @windtalker @guo-shaoge

@ti-chi-bot ti-chi-bot bot requested review from guo-shaoge and windtalker August 28, 2025 11:29
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 74.04580% with 34 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-8.5@17d2b2e). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #63268   +/-   ##
================================================
  Coverage               ?   57.1578%           
================================================
  Files                  ?       1780           
  Lines                  ?     631506           
  Branches               ?          0           
================================================
  Hits                   ?     360955           
  Misses                 ?     246273           
  Partials               ?      24278           
Flag Coverage Δ
integration 37.1332% <2.2900%> (?)
unit 72.7606% <74.0458%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.7667% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gengliqi
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Aug 28, 2025

@gengliqi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 29, 2025
@windtalker windtalker changed the title *: cherry-pick TiFlash graceful shutdown related PRs to release-7.5 *: cherry-pick TiFlash graceful shutdown related PRs to release-8.5 Sep 1, 2025
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 1, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 1, 2025
Copy link

ti-chi-bot bot commented Sep 1, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-01 04:13:35.712815048 +0000 UTC m=+759107.590646002: ☑️ agreed by windtalker.
  • 2025-09-01 06:37:58.164754615 +0000 UTC m=+767770.042585570: ☑️ agreed by guo-shaoge.

Copy link

ti-chi-bot bot commented Sep 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: guo-shaoge, windtalker, yudongusa
Once this PR has been reviewed and has the lgtm label, please assign elsa0520 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants