Skip to content

Skip oracle integration tests on AArch64 #49706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

Skip oracle integration tests on AArch64 #49706

merged 1 commit into from
Aug 27, 2025
+18 −0

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Aug 26, 2025 •
edited
Loading

Follow up to #25832 that skips unit tests on AArch64 due to segfaults when running docker.io/gvenzl/oracle-free:23-slim-faststart on AArch64.

Closes: #49718

@zakkak
Skip oracle integration tests on AArch64
305d233 
Follow up to quarkusio#25832 that skips
unit tests on AArch64 due to segfaults when running
`docker.io/gvenzl/oracle-free:23-slim-faststart` on AArch64.
@quarkus-bot quarkus-bot bot added the area/hibernate-orm Hibernate ORM label Aug 26, 2025
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Aug 26, 2025

/cc @gsmet (hibernate-orm)

@zakkak
Copy link
Contributor Author

zakkak commented Aug 26, 2025

Unfortunately this is still not enough for #47084, as -Dtest-containers and -Dstart-containers seem to override it.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Aug 26, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 305d233.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gastaldi
Copy link
Contributor

LGTM but let's make sure @zakkak's concern is resolved before we merge this

@gastaldi
Copy link
Contributor

Actually now I see @zakkak is the PR author. Should we merge this now? :)

@zakkak
Copy link
Contributor Author

zakkak commented Aug 27, 2025 •
edited
Loading

Actually now I see @zakkak is the PR author. Should we merge this now? :)

It doesn't solve the original issue I was interested in, but makes things consistent between unit tests and integration tests (at least when not setting test-containers and start-containers). I leave it to you to decide whether it's worth merging or not :) Thanks

Update:

Unfortunately this is still not enough for #47084, as -Dtest-containers and -Dstart-containers seem to override it.

It actually seems to work on MacOS. Looking...

@zakkak zakkak merged commit 42f7672 into quarkusio:main Aug 27, 2025
23 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.28 - main milestone Aug 27, 2025
@zakkak zakkak deleted the 2025-08-26-filter-tests-based-on-architecture branch August 27, 2025 06:24
zakkak added a commit to zakkak/mandrel that referenced this pull request Aug 27, 2025
@zakkak
[CI] Don't explicitly skip oracle db integration tests
04addd8 
They are skipped on the Quarkus side, see
quarkusio/quarkus#49706
This was referenced Aug 27, 2025
Closed
Merged
zakkak added a commit to graalvm/mandrel that referenced this pull request Aug 27, 2025
@zakkak
[CI] Don't explicitly skip oracle db integration tests
8501f42 
They are skipped on the Quarkus side, see
quarkusio/quarkus#49706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM kind/bugfix
Projects
None yet
Milestone
3.28 - main
Development

Successfully merging this pull request may close these issues.

Native integration tests depending on Oracle DB are failing on AArch64
2 participants
@zakkak @gastaldi