WIP use IETF BCP 47 conformant tag, starts language per-app #1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire-light42
requested changes
Aug 10, 2025
There was a problem hiding this comment.
Can you please split this pull request up into individual changes, because it modifies a lot of stuff in a lot of different and unrelated places, making it hard to test and review.
Right now you modify:
- localeconfig
- SubtitleHelper
- strings.xml
- libs.versions.toml
| @@ -1450,7 +1450,16 @@ object HlsPlaylistParser { | |||
| */ | |||
| //val labels: List<Label> = emptyList(), | |||
|
|
|||
| /** The language as an IETF BCP 47 conformant tag, or null if unknown or not applicable. */ | |||
| /** | |||
There was a problem hiding this comment.
This is media3 code, so it is unrelated to CloudStream.
.vscode/extensions.json
Outdated
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "recommendations": [ | |||
There was a problem hiding this comment.
Please remove any .vscode/* stuff as that is your local config and not something that should be pushed upstream.
* Set IETF BCP 47 language tag as default * Fix filter plugins by language when lang tag is not lowercase * Show localized language name in plugin details * Show flag on player subtitles download / auto select language
diogob003
force-pushed
the
ietf-bcp47-lang-tag
branch
from
34e93e0 to
bffa104
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1791
Start #1739