feat: support custom Prometheus registry for Kafka metrics #1899
+98
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove MaxStaleAge and AutoCleanInterval for simpler cache behavior.
c-julin
force-pushed
the
jc/metrics-hook-used
branch
from
4b3bf54 to
8d1a1ba
Compare
weeco
approved these changes
Sep 4, 2025
weeco
reviewed
Sep 4, 2025
| @@ -546,7 +547,7 @@ func (api *API) routes() *chi.Mux { | |||
| // Private routes - these should only be accessible from within Kubernetes or a protected ingress | |||
| router.Group(func(r chi.Router) { | |||
| api.Hooks.Route.ConfigInternalRouter(r) | |||
| r.Handle("/admin/metrics", promhttp.Handler()) | |||
| r.Handle("/admin/metrics", promhttp.HandlerFor(api.PrometheusRegistry.(*prometheus.Registry), promhttp.HandlerOpts{})) | |||
There was a problem hiding this comment.
I don't have a compiler at hand with this branch at the moment, but is the type assertion necessary here?
There was a problem hiding this comment.
we use the interface in the constructor which probably isn't necessary would be simpler to use the type. can update this
There was a problem hiding this comment.
https://pkg.go.dev/github.com/prometheus/client_golang/prometheus/promhttp#HandlerFor
This suggests that it also accepts the interface though :D
There was a problem hiding this comment.
Different interfaces Registerer and Gatherer i think its better to just use the type which implements both interfaces. instead we store it as a registerer and then use it as both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
client_hooks.goto support per-registry metrics instead of global promautoCachedClientProviderto accept and use injected Prometheus registry/admin/metricsendpoint to use injected registryThis allows enterprise repos to inject their own Prometheus registry while preserving all Kafka metrics collection.