vsock/tests: clarify the vsock_loopback requirement #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefano-garzarella
requested review from
stsquad,
vireshk and
epilys
as code owners
Instead of using the direct value (1), let's use the constant value provided by the vsock crate. VMADDR_CID_LOCAL is used for loopback communication, which is used in some of our test cases. Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
test_vsock_thread_backend_vsock() and test_vsock_thread_vsock_backend() tests use VMADDR_CID_LOCAL which is provided by the `vsock_loopback` kernel module. If `vsock_loopback` kernel module is not loaded, these tests will fail later with unclear messages, so it can be hard to debug. Let's fail early and print a message with the requirement. Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Add a new section to explain some requirements to run tests, e.g. `vsock_loopback` kernel module is required if `backend_vsock` feature is enabled (true by default) when running tests. Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
stefano-garzarella
force-pushed
the
vsock-testing-readme
branch
from
5e0766d to
d070b01
Compare
|
v2:
|
stsquad
approved these changes
Dec 6, 2024
vireshk
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please summarize here why the changes in this PR are needed.
Add a new section in the README to explain some requirements to run tests, e.g.
vsock_loopbackkernel module is required ifbackend_vsockfeatureis enabled (true by default) when running tests.
Use VMADDR_CID_LOCAL instead of its value in the tests and panic early
in some tests, to make clear that
vsock_loopbackis a requirementCC @stsquad
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.