[BUG] fix absolute errorbar #1579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errorbar yerr needs to be always positive in the new matplotlib versions Relates to: sktime#1571 sktime#1145
|
That's great! Looking forward to it. Looking forward to updating the new version! |
|
Thanks!!!You solve my problem! |
MartinoMensio
requested review from
benHeid,
fkiraly,
fnhirwa,
jdb78 and
yarnabrina
as code owners
|
Just updated from main to make it easy to merge (if anyone reviews it) |
|
你好，您的邮件我已经收到了哦！
|
fnhirwa
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
Hey @MartinoMensio
Nice catch😊, will merge once all tests are passing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1579 +/- ##
=======================================
Coverage ? 86.75%
=======================================
Files ? 46
Lines ? 5301
Branches ? 0
=======================================
Hits ? 4599
Misses ? 702
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue that occurrs when
max_prediction_length=1: new matplotlib versions do not allow negative yerr in the errorbar, resulting inValueError: 'yerr' must not contain negative values.See related issues for full stack traces.
I tested the fix locally and everything seems fine
fixes #1145
Checklist
max_prediction_length=1#1571 plot_prediction errorbar error #1145pre-commit install.To run hooks independent of commit, execute
pre-commit run --all-filesMake sure to have fun coding!