chore(deps): ws@8.18.3, debug@4.4.1 #5335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AviVahl
changed the title
|
heya @darrachequesne, any chance you've got time to check this out? |
|
@darrachequesne I'd also like to request this update and a quick patch release. Also I'd like to suggest using the caret symbol instead of the tilde to make requests like this appear less in the future. Thank you for your work! |
AviVahl
force-pushed
the
upgrade-ws-and-debug
branch
from
658c3bc to
40114a8
Compare
AviVahl
force-pushed
the
upgrade-ws-and-debug
branch
from
40114a8 to
bf1e01a
Compare
AviVahl
changed the title
|
rebased to latest |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
Packages use older minors of ws and debug.
New behavior
Upgraded to latest versions of ws and debug.
Other information (e.g. related issues)
Noticed these cause multiple versions on our end and conflict with openai's peerDep of ws 8.18.x. Had to do an override to get it sorted, so here's a PR.
https://github.com/websockets/ws/releases/tag/8.18.3
https://github.com/debug-js/debug/releases/tag/4.4.1