Skip to content

Properly track amp parameter on a per-grain basis #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Properly track amp parameter on a per-grain basis #287

wants to merge 1 commit into from

Conversation

scztt
Copy link
Contributor

@scztt scztt commented Apr 16, 2020

No description provided.

@scztt
Copy link
Contributor Author

scztt commented Apr 16, 2020

Potential fix for #286

@scztt scztt mentioned this pull request Apr 16, 2020
Open
Prosperoh
Prosperoh reviewed Apr 16, 2020
View reviewed changes
Copy link

@Prosperoh Prosperoh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% relevant for fixing the issue, but in the GRAIN_AMP_2 macro 'amp' is declared as 'double' when in GRAIN_AMP_3 it is declared as 'float'.

@dyfer
Copy link
Member

dyfer commented Aug 6, 2021

Hi @scztt
Would you mind rebasing this on the current main so that GitHub Actions builds this PR?

@capital-G
Copy link
Contributor

bump @scztt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Prosperoh Prosperoh Prosperoh left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
comp: plugins waiting for testing
Projects
SuperCollider development
Status: Waiting for review response
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scztt @dyfer @capital-G @Prosperoh