Fixes #38605 - Reword note about compute resources #10634
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch rewords the note that is shown below the table of compute resources on the Administer > About page on the Available Providers tab. * Remove "bundler" for development setups which not ideal for downstream products * Remove "oVirt" which is deprecated (NOTE: When I first looked at it, it still referenced oVirt. This has been fixed by Leos via b777a65.) * Recommend following the docs and using "foreman-installer" in favor of their package managers. Without a chapter, the users will start at the beginning of the guide. There is no chapter that lists all virtualization platforms and cloud providers. Co-authored-by: Thorben Denzer <denzer@atix.de>
|
cc @Thorben-D |
ekohl
requested changes
Aug 19, 2025
| @@ -60,7 +60,8 @@ | |||
| <% end %> | |||
| </tbody> | |||
| </table> | |||
| <%= _('To enable a provider, either install the OS package (e.g. foreman-libvirt) or enable the bundler group for development setup (e.g. libvirt).') %> | |||
| <%= _('You can enable additional compute resources. For more information, see') %> | |||
| <%= link_to _('provisioning hosts'), external_link_path(type: 'docs', section: "Provisioning_Hosts", chapter: ""), :rel => "external" %>. | |||
There was a problem hiding this comment.
Please use the helpers introduced in b566ea8. I think this should work:
Suggested change
| <%= link_to _('provisioning hosts'), external_link_path(type: 'docs', section: "Provisioning_Hosts", chapter: ""), :rel => "external" %>. | |
| <%= link_to _('provisioning hosts'), documentation_url('Provisioning_Hosts', type: 'docs'), :rel => "external" %>. |
| @@ -60,7 +60,8 @@ | |||
| <% end %> | |||
| </tbody> | |||
| </table> | |||
| <%= _('To enable a provider, either install the OS package (e.g. foreman-libvirt) or enable the bundler group for development setup (e.g. libvirt).') %> | |||
| <%= _('You can enable additional compute resources. For more information, see') %> | |||
There was a problem hiding this comment.
Splitting sentences in translation is always a bad a idea and must be avoided. Please use string interpolation instead. See https://projects.theforeman.org/projects/foreman/wiki/Translating. Though I'm not 100% sure what the current best practice around links is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch rewords the note that is shown below the table of compute resources on the Administer > About page on the Available Providers tab.
Without a chapter, the users will start at the beginning of the guide. There is no chapter that lists all virtualization platforms and cloud providers.