Skip to content

feat:新增Y周是否可拖动参数及判断 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2023
Merged

feat:新增Y周是否可拖动参数及判断 #11

merged 3 commits into from
Apr 14, 2023

Conversation

Amber-Nan
Copy link
Contributor

No description provided.

jaywcjlove
jaywcjlove reviewed Apr 14, 2023
View reviewed changes
core/src/Tab.tsx Outdated
@@ -12,6 +12,7 @@ export const ItemTypes = {
export interface TabProps extends React.DetailedHTMLProps<React.HTMLAttributes<HTMLDivElement>, HTMLDivElement> {
id: string;
index?: number;
AxisYType?: boolean; //Y轴是否可上下拖动
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

props “参数” 命名应该使用小驼峰，开头字母小写，

组件名称和类型名称使用大驼峰

这个 props 可以命名为 dragableY 更为准确表达意思

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Amber-Nan

@Amber-Nan Amber-Nan closed this Apr 14, 2023
@jaywcjlove jaywcjlove reopened this Apr 14, 2023
jaywcjlove
jaywcjlove reviewed Apr 14, 2023
View reviewed changes
core/src/Tab.tsx
@@ -12,7 +12,7 @@ export const ItemTypes = {
export interface TabProps extends React.DetailedHTMLProps<React.HTMLAttributes<HTMLDivElement>, HTMLDivElement> {
id: string;
index?: number;
yAxisType?: boolean; //Y轴是否可上下拖动
dragableY?: boolean; //Y轴是否可上下拖动
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Amber-Nan 下面注释方法有代码提示

  /** Y轴是否可上下拖动 */
  dragableY?: boolean;

@jaywcjlove jaywcjlove merged commit e7b3df7 into uiwjs:main Apr 14, 2023
github-actions bot pushed a commit that referenced this pull request Apr 14, 2023
@jaywcjlove
v0.0.9 feat: add dragableY props. (#11)
a9911f0 
* feat:新增Y周是否可拖动参数及判断

* fix:修改参数为驼峰

* fix:修改y轴拖动参数名称

---------

Co-authored-by: 杨楠 <yangnan@ane56.com> e7b3df7
jaywcjlove added a commit that referenced this pull request Apr 14, 2023
@jaywcjlove
released v0.0.10 (#11)
91ac461
github-actions bot pushed a commit that referenced this pull request Apr 14, 2023
@jaywcjlove
v0.0.10 released v0.0.10 (#11) 91ac461
9ebfe7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaywcjlove jaywcjlove jaywcjlove left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amber-Nan @jaywcjlove