Fix/min_train_samples and min_train_series_length are properly computed #2353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before merging this PR:
Fixes fixes #2264, fixes #1823.
Summary
min_train_series_length
andmin_train_samples
are now properly depending on each othermin_train_samples
attribute was relaxed for models such asARIMA
orLinearRegression
, it is now the value under which, the model raises an errorhistorical_forecasts()
now rely onmin_train_series_length
to assess how many steps must be set aside whenretrain=True
andtrain_length=None
.min_train_past_covariates_series_length
andmin_train_future_covariates_series_length
attributes, they assume that the series are optimally aligned with the targetOther Information