hiredis-vip: add new package #8039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waruqi
reviewed
Sep 3, 2025
waruqi
reviewed
Sep 3, 2025
packages/h/hiredis-vip/xmake.lua
Outdated
| if not package:config("debug") or package:is_mode("release") then | ||
| table.insert(configs, "DEBUG=") | ||
| end | ||
| os.vrunv("make install ", configs) |
There was a problem hiding this comment.
you should use package.tools.make to install it.
There was a problem hiding this comment.
如果用 package.tools.make的话，发现configs只会在make时生效，第二步执行 make install时就没了，所以直接用的os.vrunv
There was a problem hiding this comment.
I think at this case we have to follow existing recipe structure. That is why last lines of recipes should use tool not vrun.
waruqi
reviewed
Sep 3, 2025
waruqi
reviewed
Sep 3, 2025
waruqi
reviewed
Sep 3, 2025
luadebug
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.