-
Notifications
You must be signed in to change notification settings - Fork 82
feat: add raw values to barcode scanning #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add raw values to barcode scanning #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @mahmoudsamyhamed 🙏🏼
barcode-scanning/android/src/main/java/com/rnmlkit/barcodescanning/BarcodeScanningModule.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 🚀
Just one minor nit.
@mahmoudsamyhamed Let's also update the example app to show both |
ea6ed67
to
7213f8d
Compare
7213f8d
to
0b58f67
Compare
Resolves #39 by adding
rawValues
to barcode scanning.Fixes #39.