Skip to content

feat: add raw values to barcode scanning #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 6, 2025
Merged

feat: add raw values to barcode scanning #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e20624e
feat: add raw values to barcode scanning
Sep 5, 2025
83ebeab
feat: add raw value and display value
Sep 5, 2025
d510d33
feat: use display and raw value in example
Sep 5, 2025
0b58f67
chore: use recommended format
Sep 6, 2025
f950bb3
feat: dispaly json of item in example
Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ode-scanning/android/src/main/java/com/rnmlkit/barcodescanning/BarcodeScanningModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ public void onSuccess(List<Barcode> barcodes) {
WritableMap map = Arguments.createMap();
map.putString("value", barcode.getRawValue());
map.putDouble("format", barcode.getFormat());
map.putString("displayValue", barcode.getDisplayValue());
map.putString("rawValue", barcode.getRawValue());
result.pushMap(map);
}
promise.resolve(result);
Expand Down
7 changes: 6 additions & 1 deletion barcode-scanning/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,12 @@ export enum BarcodeFormat {

export interface Barcode {
format: BarcodeFormat;
/**
* @deprecated `value` is deprecated and will be removed in a future release please use `displayValue` or `rawValue` instead
*/
value: string;
rawValue: string;
displayValue: string;
}

interface IBarcodeScanning {
Expand All @@ -44,4 +49,4 @@ const BarcodeScanning: IBarcodeScanning = NativeModules.BarcodeScanning
}
);

export default BarcodeScanning;
export default BarcodeScanning;
15 changes: 8 additions & 7 deletions barcode-scanning/ios/BarcodeScanning.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,9 @@ @implementation BarcodeScanning

RCT_EXPORT_MODULE()

RCT_EXPORT_METHOD(scan
: (nonnull NSString *)url resolver
: (RCTPromiseResolveBlock)resolve rejecter
: (RCTPromiseRejectBlock)reject) {
RCT_EXPORT_METHOD(scan:(nonnull NSString *)url
resolver:(RCTPromiseResolveBlock)resolve
rejecter:(RCTPromiseRejectBlock)reject) {
NSURL *_url = [NSURL URLWithString:url];
NSData *imageData = [NSData dataWithContentsOfURL:_url];
UIImage *image = [UIImage imageWithData:imageData];
Expand Down Expand Up @@ -40,10 +39,12 @@ @implementation BarcodeScanning
default:
format = @(barcode.format);
}

[result addObject:@{
@"value": barcode.displayValue,
@"format": format
@"value" : barcode.displayValue,
@"format" : format,
@"rawValue" : barcode.rawValue,
@"displayValue" : barcode.displayValue
}];
}

Expand Down
8 changes: 5 additions & 3 deletions example/src/barcode-scanning/BarcodeScanningScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,12 @@ const BarcodeScanningScreen = () => {
<FlatList
data={barcodes}
style={styles.list}
keyExtractor={barcode => `${barcode.format}-${barcode.value}`}
renderItem={({item}) => (
keyExtractor={barcode =>
`${barcode.format}-${barcode.displayValue}-${barcode.rawValue}`
}
renderItem={({ item }) => (
<LabelTile>
{item.value} - {item.format}
{JSON.stringify(item, undefined, 2)}
</LabelTile>
)}
/>
Expand Down