🐛 Fix detection of a completed Deployment #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per somewhat hidden documentation [1], we must inspect the Progressing condition and its Reason. Available is still True directly after an update because the old replica is still running. On top of that, stop reconciliation with a fatal error when the deployment no longer progresses. Unfortunately, client-go does not expose the necessary Reason constants, so I have to hardcode them based on the values from the documentation and real-world testing. [1] https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#complete-deployment Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
metal3-io-bot
added
the
size/S
|
/hold Even this is not enough. |
metal3-io-bot
added
the
do-not-merge/hold
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
|
/hold cancel I think this approach works |
metal3-io-bot
removed
the
do-not-merge/hold
|
/cc @lentzi90 Your expertise is needed here. This patch is an outcome of trial-and-error. I don't think there are better options but I might very well be missing something. |
lentzi90
reviewed
Apr 11, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per somewhat hidden documentation [1], we must inspect the Progressing
condition and its Reason. Available is still True directly after an update
because the old replica is still running.
On top of that, stop reconciliation with a fatal error when the
deployment no longer progresses.
Unfortunately, client-go does not expose the necessary Reason constants,
so I have to hardcode them based on the values from the documentation
and real-world testing.
[1] https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#complete-deployment
Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com